Add a failing test for SR-13785 #34462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ility when dealing with @_implementationOnly imports
|
@swift-ci please test |
|
@swift-ci please test |
hlopko
approved these changes
Oct 27, 2020
|
Build failed |
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
ainu-bot
added a commit
to google/swift
that referenced
this pull request
Oct 28, 2020
* 'main' of github.com:apple/swift: Add a failing test for SR-13785 (swiftlang#34462)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test for SR-13785:
If a symbol comes from two modules, one of which is marked as
@_implementationOnly, Swift may choose the@_implementationOnlysource and then error out due to the symbol being hidden.Ideally, Swift would consider all sources for the symbol and recognize that the symbol is not hidden behind
@_implementationOnlyin all modules.